Review Request: [GCI] Adding d-pointers (part #1)
Shou Ya
shouyatf at gmail.com
Mon Dec 10 13:19:45 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107610/
-----------------------------------------------------------
(Updated Dec. 10, 2012, 1:19 p.m.)
Review request for Calligra and Jarosław Staniek.
Changes
-------
Fixed the problems Staniek mentioned.
Description
-------
I've done with it for all the classes, please review.
Good luck!
Diffs (updated)
-----
kexi/migration/importwizard.h 80d0e81
kexi/migration/importwizard.cpp c0f120f
kexi/migration/keximigrate.h 8b8ce71
kexi/migration/keximigrate.cpp 4e53d2d
kexi/plugins/forms/kexiformscrollview.h a7dc9d0
kexi/plugins/forms/kexiformscrollview.cpp cad94c7
kexi/plugins/forms/kexiformview.h f09aec2
kexi/plugins/forms/kexiformview.cpp b011808
kexi/plugins/forms/widgets/kexidbform.h c2e0eca
kexi/plugins/forms/widgets/kexidbform.cpp c2dd1c5
kexi/plugins/forms/widgets/kexidbutils.h d02e394
kexi/plugins/forms/widgets/kexidbutils.cpp 9d60a80
kexi/plugins/importexport/csv/kexicsvwidgets.h 12150ed
kexi/plugins/importexport/csv/kexicsvwidgets.cpp 2c6f8c7
kexi/plugins/reports/InternalSourceSelector.h cb8b0b4
kexi/plugins/reports/kexidbreportdata.h deb4687
kexi/plugins/reports/kexidbreportdata.cpp b6f5edb
kexi/plugins/reports/keximigratereportdata.h e4a88630
kexi/plugins/reports/keximigratereportdata.cpp cf8abe8
kexi/plugins/reports/kexisourceselector.h e44e15e
kexi/plugins/reports/kexisourceselector.cpp 808ae5b
kexi/widget/KexiNameDialog.h 429ee8b
kexi/widget/KexiNameDialog.cpp 643fc22
kexi/widget/KexiNameWidget.h 5947a58
kexi/widget/KexiNameWidget.cpp 021bc9f
kexi/widget/KexiProjectSelectorWidget.h 647d8a4
kexi/widget/KexiProjectSelectorWidget.cpp a8e1f15
kexi/widget/dataviewcommon/KexiTableViewColumn.h 2248c65
kexi/widget/dataviewcommon/KexiTableViewColumn.cpp 14c2c35
kexi/widget/dataviewcommon/kexidataawarepropertyset.h 3a4c576
kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp b7c0043
kexi/widget/dataviewcommon/kexidataawareview.h 600455a
kexi/widget/dataviewcommon/kexidataawareview.cpp d608958
kexi/widget/fields/KexiFieldListModelItem.h 5486a77
kexi/widget/fields/KexiFieldListModelItem.cpp fe55b12
kexi/widget/fields/KexiFieldListView.h 1ea94bd
kexi/widget/fields/KexiFieldListView.cpp bed42a0
kexi/widget/kexicharencodingcombobox.h 74fdfb2
kexi/widget/kexicharencodingcombobox.cpp 4be3315
kexi/widget/kexidbconnectionwidget.h 234235a
kexi/widget/kexidbconnectionwidget.cpp 38cd1a2
kexi/widget/kexidbdrivercombobox.h 8c07307
kexi/widget/kexidbdrivercombobox.cpp d85fe4a
kexi/widget/kexiscrollview.h 4fc6f85
kexi/widget/kexiscrollview.cpp 5a94228
kexi/widget/kexislider.h 36c2f73
kexi/widget/kexislider.cpp 4545dc8
kexi/widget/navigator/KexiProjectModelItem.h fe04381
kexi/widget/navigator/KexiProjectModelItem.cpp 764c17a
kexi/widget/navigator/KexiProjectNavigator.h 4f32e31
kexi/widget/navigator/KexiProjectNavigator.cpp 284ef34
kexi/widget/tableview/kexidatatable.h ca9c22a
kexi/widget/tableview/kexidatatable.cpp b2d4c74
kexi/widget/utils/KexiDockableWidget.h 23d809d
kexi/widget/utils/KexiDockableWidget.cpp d1060cb
kexi/widget/utils/kexicomboboxdropdownbutton.h 20957db
kexi/widget/utils/kexicomboboxdropdownbutton.cpp d724191
kexi/widget/utils/kexidatetimeformatter.h 5d8e9fe
kexi/widget/utils/kexidatetimeformatter.cpp fed7692
kexi/widget/utils/kexitooltip.h c0cf3b5
kexi/widget/utils/kexitooltip.cpp bd2e7c4
Diff: http://git.reviewboard.kde.org/r/107610/diff/
Testing
-------
Thanks,
Shou Ya
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121210/028ea60a/attachment.htm>
More information about the calligra-devel
mailing list