Review Request: [GCI] Adding d-pointers to kexi/main

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107648/#review23227
-----------------------------------------------------------



kexi/main/startup/KexiStartup.h
<http://git.reviewboard.kde.org/r/107648/#comment17785>

    if we change the 1st arg to pointer, please also consistently change detectedDriverName to pointer



kexi/main/startup/KexiStartup.cpp
<http://git.reviewboard.kde.org/r/107648/#comment17786>

    bug: cdata = &data



kexi/main/startup/KexiStartup.cpp
<http://git.reviewboard.kde.org/r/107648/#comment17787>

    move '{' to a new line



kexi/main/startup/KexiStartup.cpp
<http://git.reviewboard.kde.org/r/107648/#comment17788>

    Bug/crash: Cannot get pointer object returned by value.
    
    Instead use temporary; full code:
    
    KexiStartupData::Import importData = KexiStartupData::importActionData();
    const tristate res = detectActionForFile(&importData, detectedDriverName, cdata.driverName, selFile);
    if (true != res)
          return res;
    KexiStartupData::setImportActionData(importData);
    



kexi/main/startup/KexiStartup.cpp
<http://git.reviewboard.kde.org/r/107648/#comment17789>

    Again bug/crash: Cannot get pointer object returned by value.
    
    Instead use temporary; see advice from line 676.



kexi/main/startup/KexiTemplatesModel.cpp
<http://git.reviewboard.kde.org/r/107648/#comment17792>

    parent arg not needed here



kexi/main/startup/KexiTemplatesModel.cpp
<http://git.reviewboard.kde.org/r/107648/#comment17791>

    missing initialization of templateCategories; parent arg not needed here



kexi/main/startup/KexiTemplatesModel.cpp
<http://git.reviewboard.kde.org/r/107648/#comment17793>

    Missing ~KexiTemplatesModel() here with 'delete d'.


- Jarosław Staniek


On Dec. 9, 2012, 5:50 p.m., Andrey Inishev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107648/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2012, 5:50 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Patch adding d-pointers to kexi/main
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.cpp ccc885a 
>   kexi/main/startup/KexiStartup.h 9694f53 
>   kexi/main/startup/KexiStartup.cpp 23d2a56 
>   kexi/main/startup/KexiTemplatesModel.h 995930e 
>   kexi/main/startup/KexiTemplatesModel.cpp 80d5bf5 
> 
> Diff: http://git.reviewboard.kde.org/r/107648/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey Inishev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121209/cec0aa11/attachment.htm>