Review Request: [GCI] Adding d-pointers to kexi/kexiutils

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107649/#review23224
-----------------------------------------------------------



kexi/kexiutils/FlowLayout.cpp
<http://git.reviewboard.kde.org/r/107649/#comment17779>

    Please remove this commened-out code



kexi/kexiutils/FlowLayout.cpp
<http://git.reviewboard.kde.org/r/107649/#comment17780>

    missing 'qDeleteAll(list)'



kexi/kexiutils/SmallToolButton.cpp
<http://git.reviewboard.kde.org/r/107649/#comment17781>

    missing 'delete d'



kexi/kexiutils/styleproxy.h
<http://git.reviewboard.kde.org/r/107649/#comment17783>

    Exception: we do not want d-pointer in StyleProxy.



kexi/kexiutils/styleproxy.cpp
<http://git.reviewboard.kde.org/r/107649/#comment17784>

    Exception: we do not want d-pointer in StyleProxy.


- Jarosław Staniek


On Dec. 9, 2012, 5:51 p.m., Andrey Inishev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107649/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2012, 5:51 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Patch adding d-pointers to kexi/kexiutils
> 
> 
> Diffs
> -----
> 
>   kexi/kexiutils/FlowLayout.h eaf928f 
>   kexi/kexiutils/FlowLayout.cpp 34c7fc4 
>   kexi/kexiutils/SmallToolButton.h d0d6feb 
>   kexi/kexiutils/SmallToolButton.cpp 6f83fae 
>   kexi/kexiutils/longlongvalidator.h f620c0e 
>   kexi/kexiutils/longlongvalidator.cpp a2677ad 
>   kexi/kexiutils/styleproxy.h 1d2aae3 
>   kexi/kexiutils/styleproxy.cpp e785b64 
> 
> Diff: http://git.reviewboard.kde.org/r/107649/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey Inishev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121209/2666c5a0/attachment.htm>