Review Request: Adds d-pointers to Kexi classes in kexi/core

Sun Dec 9 20:56:04 GMT 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107515/#review23221
-----------------------------------------------------------

Please fix the issues very carefully.

kexi/core/KexiView.h
<http://git.reviewboard.kde.org/r/107515/#comment17744>

    Please use 'const QString &iconName'

kexi/core/KexiView.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17745>

    Please use 'const QString &iconName'

kexi/core/kexidataiteminterface.h
<http://git.reviewboard.kde.org/r/107515/#comment17746>

    -> by calling setHasFocusableWidget(bool)

kexi/core/kexidataiteminterface.h
<http://git.reviewboard.kde.org/r/107515/#comment17747>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexidataiteminterface.h
<http://git.reviewboard.kde.org/r/107515/#comment17748>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexidataiteminterface.h
<http://git.reviewboard.kde.org/r/107515/#comment17749>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexidataiteminterface.h
<http://git.reviewboard.kde.org/r/107515/#comment17750>

    please insert empty space between methods and docs

kexi/core/kexidataiteminterface.h
<http://git.reviewboard.kde.org/r/107515/#comment17751>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexidataiteminterface.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17752>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexidataiteminterface.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17753>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexidataiteminterface.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17754>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexidataiteminterface.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17755>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexiinternalpart.h
<http://git.reviewboard.kde.org/r/107515/#comment17756>

    Please remove this empty row 

kexi/core/kexiinternalpart.h
<http://git.reviewboard.kde.org/r/107515/#comment17757>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexiinternalpart.h
<http://git.reviewboard.kde.org/r/107515/#comment17758>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexiinternalpart.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17759>

    add 'delete d'

kexi/core/kexiinternalpart.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17760>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexiinternalpart.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17761>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexipartmanager.h
<http://git.reviewboard.kde.org/r/107515/#comment17762>

    please remove this empty row

kexi/core/kexipartmanager.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17763>

    please remove these two commented-out rows

kexi/core/kexiprojectconnectiondata.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17764>

    not needed, already passed to Private constructor

kexi/core/kexiprojectconnectiondata.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17765>

    missing 'delete d'

kexi/core/kexiprojectconnectiondata.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17766>

    this won't compile

kexi/core/kexistartupdata.h
<http://git.reviewboard.kde.org/r/107515/#comment17767>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexistartupdata.h
<http://git.reviewboard.kde.org/r/107515/#comment17769>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexistartupdata.h
<http://git.reviewboard.kde.org/r/107515/#comment17770>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexistartupdata.h
<http://git.reviewboard.kde.org/r/107515/#comment17771>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexistartupdata.h
<http://git.reviewboard.kde.org/r/107515/#comment17772>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexistartupdata.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17773>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexistartupdata.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17774>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexistartupdata.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17775>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexistartupdata.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17776>

    Never use meaningless names such as 'x';

    x -> set

kexi/core/kexitextmsghandler.cpp
<http://git.reviewboard.kde.org/r/107515/#comment17777>

    missing 'delete d'

- Jarosław Staniek

On Dec. 7, 2012, 12:10 p.m., Andrey Inishev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107515/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2012, 12:10 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Patch for kexi/core, http://www.google-melange.com/gci/task/view/google/gci2012/8009216
> 
> 
> Diffs
> -----
> 
>   kexi/core/KexiView.h ae0376e 
>   kexi/core/KexiView.cpp a59c904 
>   kexi/core/KexiWindow.cpp 9136fde 
>   kexi/core/kexidataiteminterface.h 4258451 
>   kexi/core/kexidataiteminterface.cpp a5ad759 
>   kexi/core/kexiinternalpart.h 08178ed 
>   kexi/core/kexiinternalpart.cpp 253e77d 
>   kexi/core/kexipartmanager.h 9cb2356 
>   kexi/core/kexipartmanager.cpp cf17f3a 
>   kexi/core/kexiprojectconnectiondata.h b88a1f9 
>   kexi/core/kexiprojectconnectiondata.cpp 0df2793 
>   kexi/core/kexistartupdata.h 2147465 
>   kexi/core/kexistartupdata.cpp 45fdd71 
>   kexi/core/kexitextmsghandler.h 29adc64 
>   kexi/core/kexitextmsghandler.cpp 71011c9 
> 
> Diff: http://git.reviewboard.kde.org/r/107515/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey Inishev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121209/59f4446e/attachment.htm>