Review Request: change suffix to .html

C. Boemann cbr at boemann.dk
Sat Dec 8 10:18:13 GMT 2012



> On Dec. 8, 2012, 6:17 a.m., Friedrich W. H. Kossebau wrote:
> > But that will still overwrite the suffix of the filename the users chose and hardcode it to ".html", no?
> > At least this was the behaviour I saw on Windows, if you choose a filename output.htm (well, Windows, users do it still like there) or output.html, the suffix was always changed to .xhtml.
> > I rather think the filename (incl. suffix) like the user selected should be used for the output file, no better-knowing of the filter should happen. E.g. the author of the lines which hardcode to ".xhtml" (and others) might even prefer the ".xhtml" suffix and will be annoyed that it now gets turned to ".html" whatever he/she enters in the filedialog :)

Totally fair argument, and I agree. Ok I'll drop this request :)


- C.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107631/#review23150
-----------------------------------------------------------


On Dec. 8, 2012, 1:11 a.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107631/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2012, 1:11 a.m.)
> 
> 
> Review request for Calligra and Inge Wallin.
> 
> 
> Description
> -------
> 
> change suffix to .html as that is what people expect rather than .xhtml
> 
> ok to backport?
> 
> 
> Diffs
> -----
> 
>   filters/words/epub/OdtHtmlConverter.cpp 3c12165 
> 
> Diff: http://git.reviewboard.kde.org/r/107631/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121208/be628647/attachment.htm>


More information about the calligra-devel mailing list