Review Request: [GCI] Adding d-pointers (part #1)

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107610/#review23140
-----------------------------------------------------------



kexi/migration/importwizard.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17674>

    I propose to move all these initializations to Private's initialization list



kexi/migration/importwizard.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17683>

    missing 'delete d'



kexi/migration/keximigrate.h
<http://git.reviewboard.kde.org/r/107610/#comment17684>

    These attributes should be removed because were moved to Private. 



kexi/migration/keximigrate.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17685>

    fix indentation here and in lines below



kexi/plugins/importexport/csv/kexicsvwidgets.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17686>

    Please separate blocks with one empty line.



kexi/plugins/reports/kexidbreportdata.h
<http://git.reviewboard.kde.org/r/107610/#comment17687>

    Since we're cleaning up, please move the private block to the end of the declaration.



kexi/plugins/reports/kexidbreportdata.h
<http://git.reviewboard.kde.org/r/107610/#comment17688>

    private methods go up before 'class Private'



kexi/plugins/reports/keximigratereportdata.h
<http://git.reviewboard.kde.org/r/107610/#comment17689>

    Like before, please move private section to the bottom.



kexi/plugins/reports/keximigratereportdata.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17690>

    Please move to Private's initialization list so position is always initialized to 0.



kexi/plugins/reports/kexisourceselector.h
<http://git.reviewboard.kde.org/r/107610/#comment17692>

    please move private section to line 53



kexi/plugins/reports/kexisourceselector.h
<http://git.reviewboard.kde.org/r/107610/#comment17691>

    please move to line 46



kexi/plugins/reports/kexisourceselector.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17693>

    please move initialization to the Private's initialization list.



kexi/widget/KexiNameWidget.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17694>

    Please move '{' to a new line; use one empty line between blocks.



kexi/widget/KexiNameWidget.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17695>

    Please move '{' to a new line; use one empty line between blocks.



kexi/widget/KexiNameWidget.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17696>

    Please move '{' to a new line; use one empty line between blocks.



kexi/widget/KexiNameWidget.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17697>

    please remove this unused code



kexi/widget/dataviewcommon/KexiTableViewColumn.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17698>

    Please move '{' to a new line; use one empty line between blocks.



kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17699>

    move to ~Private, and add 'delete d' here



kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17700>

    Please move '{' to a new line; use one empty line between blocks.



kexi/widget/dataviewcommon/kexidataawareview.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17701>

    Please move '{' to a new line; use one empty line between blocks.
    



kexi/widget/fields/KexiFieldListModelItem.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17702>

    bug: should be fname, dtype



kexi/widget/navigator/KexiProjectModelItem.h
<http://git.reviewboard.kde.org/r/107610/#comment17703>

    please remove this unused code



kexi/widget/navigator/KexiProjectModelItem.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17706>

    please remove fifoSorting (unused)



kexi/widget/navigator/KexiProjectModelItem.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17705>

    please remove



kexi/widget/utils/kexidatetimeformatter.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17707>

    delete hmsRegExp and hmRegExp in ~Private



kexi/widget/utils/kexidatetimeformatter.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17708>

    Please move '{' to a new line.



kexi/widget/utils/kexidatetimeformatter.cpp
<http://git.reviewboard.kde.org/r/107610/#comment17709>

    fix indent


- Jarosław Staniek


On Dec. 7, 2012, 1:01 a.m., Shou Ya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107610/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2012, 1:01 a.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> I've done with it for all the classes, please review.
> 
> Good luck!
> 
> 
> Diffs
> -----
> 
>   kexi/migration/importwizard.h 80d0e81 
>   kexi/migration/importwizard.cpp c0f120f 
>   kexi/migration/keximigrate.h 8b8ce71 
>   kexi/migration/keximigrate.cpp 4e53d2d 
>   kexi/plugins/importexport/csv/kexicsvwidgets.h 12150ed 
>   kexi/plugins/importexport/csv/kexicsvwidgets.cpp 2c6f8c7 
>   kexi/plugins/reports/kexidbreportdata.h deb4687 
>   kexi/plugins/reports/kexidbreportdata.cpp b6f5edb 
>   kexi/plugins/reports/keximigratereportdata.h e4a88630 
>   kexi/plugins/reports/keximigratereportdata.cpp cf8abe8 
>   kexi/plugins/reports/kexisourceselector.h e44e15e 
>   kexi/plugins/reports/kexisourceselector.cpp 808ae5b 
>   kexi/widget/KexiNameDialog.h 429ee8b 
>   kexi/widget/KexiNameDialog.cpp 643fc22 
>   kexi/widget/KexiNameWidget.h 5947a58 
>   kexi/widget/KexiNameWidget.cpp 021bc9f 
>   kexi/widget/dataviewcommon/KexiTableViewColumn.h 2248c65 
>   kexi/widget/dataviewcommon/KexiTableViewColumn.cpp 14c2c35 
>   kexi/widget/dataviewcommon/kexidataawarepropertyset.h 3a4c576 
>   kexi/widget/dataviewcommon/kexidataawarepropertyset.cpp b7c0043 
>   kexi/widget/dataviewcommon/kexidataawareview.h 600455a 
>   kexi/widget/dataviewcommon/kexidataawareview.cpp d608958 
>   kexi/widget/fields/KexiFieldListModelItem.h 5486a77 
>   kexi/widget/fields/KexiFieldListModelItem.cpp fe55b12 
>   kexi/widget/fields/KexiFieldListView.h 1ea94bd 
>   kexi/widget/fields/KexiFieldListView.cpp bed42a0 
>   kexi/widget/kexislider.h 36c2f73 
>   kexi/widget/kexislider.cpp 4545dc8 
>   kexi/widget/navigator/KexiProjectModelItem.h fe04381 
>   kexi/widget/navigator/KexiProjectModelItem.cpp 764c17a 
>   kexi/widget/navigator/KexiProjectNavigator.h 4f32e31 
>   kexi/widget/navigator/KexiProjectNavigator.cpp 284ef34 
>   kexi/widget/tableview/kexidatatable.h ca9c22a 
>   kexi/widget/tableview/kexidatatable.cpp b2d4c74 
>   kexi/widget/utils/KexiDockableWidget.h 23d809d 
>   kexi/widget/utils/KexiDockableWidget.cpp d1060cb 
>   kexi/widget/utils/kexicomboboxdropdownbutton.h 20957db 
>   kexi/widget/utils/kexicomboboxdropdownbutton.cpp d724191 
>   kexi/widget/utils/kexidatetimeformatter.h 5d8e9fe 
>   kexi/widget/utils/kexidatetimeformatter.cpp fed7692 
>   kexi/widget/utils/kexitooltip.h c0cf3b5 
>   kexi/widget/utils/kexitooltip.cpp bd2e7c4 
> 
> Diff: http://git.reviewboard.kde.org/r/107610/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shou Ya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121208/196ef78f/attachment.htm>