Review Request: fix KoDocumentRdf::findXmlId(KoTextEditor *) to find the correct xmlId

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107617/#review23105
-----------------------------------------------------------


Yeah I've been looking at this for half a day now, and although you ae right it doesn't find the closest I also think it a broken idea to find the closest

- C. Boemann


On Dec. 6, 2012, 8:37 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107617/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2012, 8:37 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Currently the code does not really seem to do what the API dox proposes: "find the xmlid of the semitem that is at or surrounding the cursor given. As with findExtent() this will be only the most nested semitem."
> 
> Attached patch changes that, in a naive approach. Correct one?
> Or does the API dox need adaption?
> 
> Okay to commit to 2.6 and forward port to master?
> 
> 
> Diffs
> -----
> 
>   libs/main/rdf/KoDocumentRdf.cpp 49275c4 
> 
> Diff: http://git.reviewboard.kde.org/r/107617/diff/
> 
> 
> Testing
> -------
> 
> Selecting tables in orpheus works for me with this patch.
> 
> But there is a problem: on exchanging the cell contents the bookmark start moves behind the new content in the first cell. So putting the cursor onto the new content will fall outside of the bookmark range. Similar problem at the end. This needs to be fixed separately.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121206/a2022fe3/attachment.htm>