Review Request: Implement triple button widget

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107530/#review23093
-----------------------------------------------------------


I would use your group button in Kexi, please look at the blog from 3+ years ago :) http://blogs.kde.org/node/4104


libs/widgets/KoTripleButton.h
<http://git.reviewboard.kde.org/r/107530/#comment17638>

    Let's add groupPosition Q_PROPERTY here...



libs/widgets/KoTripleButton.h
<http://git.reviewboard.kde.org/r/107530/#comment17639>

    NoGroup would be better



libs/widgets/KoTripleButton.h
<http://git.reviewboard.kde.org/r/107530/#comment17636>

    +explicit 



libs/widgets/KoTripleButton.h
<http://git.reviewboard.kde.org/r/107530/#comment17637>

    Let's have GroupPosition groupPosition() const and use if in property.



libs/widgets/KoTripleButton.cpp
<http://git.reviewboard.kde.org/r/107530/#comment17641>

    groupPosition is cleaner



libs/widgets/KoTripleButton.cpp
<http://git.reviewboard.kde.org/r/107530/#comment17640>

    Memory leak, missing destructor with 'delete d;'


- Jarosław Staniek


On Dec. 6, 2012, 5:17 p.m., Jean-Nicolas Artaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107530/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2012, 5:17 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Implement triple button widget in the calligra widget libs.
> This also can be used for double buttons (like in gwenview for instance).
> 
> 
> Diffs
> -----
> 
>   libs/widgets/CMakeLists.txt 10e4e09 
>   libs/widgets/KoStrokeConfigWidget.cpp d0a8eb9 
>   libs/widgets/KoTripleButton.h PRE-CREATION 
>   libs/widgets/KoTripleButton.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107530/diff/
> 
> 
> Testing
> -------
> 
> Use the triple button on the property docker.
> 
> 
> Screenshots
> -----------
> 
> Strocke properties docker with the triple buttons
>   http://git.reviewboard.kde.org/r/107530/s/865/
> MS Word uses it every where
>   http://git.reviewboard.kde.org/r/107530/s/869/
> Normal Mode, Normal Size
>   http://git.reviewboard.kde.org/r/107530/s/875/
> Flat Mode, Normal Size
>   http://git.reviewboard.kde.org/r/107530/s/876/
> 
> 
> Thanks,
> 
> Jean-Nicolas Artaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121206/f0070146/attachment.htm>