Review Request: import csv-file into existing table

[Oleg Kukharchuk]

> On Dec. 2, 2012, 12:41 a.m., Jarosław Staniek wrote:
> > 
> > 
> > - Perhaps it's earlier bug but please look at numbers on the vertical header (it's "2, 2, 3", instead of "1, 2, 3"): http://wstaw.org/m/2012/12/02/plasma-desktoppx2099.png
> > Test data (autodetected separator is ','):
> > ,"a",,"b"
> > ,,,
> > ,,"c"
> > "d",
> > 
> > - I am sorry for confusion, after further testing the assistant's buttons, I propose: in 'Importing...' page Next button should be hidden; on the first page Back button should be hidden; Import... button should be visible only when it's available
> > 
> > - On the 'Choose Name of Destination Table' page, if no destination table is selected, "Next" button should be disabled.
> > 
> > - If destination table T was opened prior to importing (appending to T) it could be best if we refresh its contents. For now we can do that by closing and opening the table's window.
> > 
> > - Later check: what to do if we have the destination table T opened in desingn mode and it's 'dirty' (changed)? We have to ask the user about confirmation of dropping the Design before we can continue.
> 
> Oleg Kukharchuk wrote:
>     about vertical header. looks like a bug. but what should we display here. just row number in view or row number from source csv-file?
>     
>     maybe I'm inattentive as usual, but I didn't find any API to get KexiWindows list or get kexiwindow using a partitem. can you advise something?
> 
> Jarosław Staniek wrote:
>     1. I propose to display row number of the destination data (e.g. in the view).
>     
>     2. We have KexiWindow* KexiMainWindow::Private::openedWindowFor(const KexiPart::Item* item) but indeed we need to make it public through declaring pure public virtual KexiWindow* KexiMainWindowIface::openedWindowFor(const KexiPart::Item* item) and inplementing it in KexiMainWindow.

fixed


- Oleg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107330/#review22901
-----------------------------------------------------------


On Dec. 1, 2012, 11:59 p.m., Oleg Kukharchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107330/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2012, 11:59 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
> 
> 
> Description
> -------
> 
> * moved to a KAssistantDialog
> * added ability to import into an existent table
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h 15be3504dfc54877bc45d81eb7e59a72f70c9c5a 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 5176299599ab034bf256f07ee2651d8a4babb3a0 
> 
> Diff: http://git.reviewboard.kde.org/r/107330/diff/
> 
> 
> Testing
> -------
> 
> tested on local branch
> and additional testing needed
> 
> (code was not cleaned up yet)
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121205/c9dda52f/attachment.htm>