Review Request: add d-pointer for KexiScrollView
Jarosław Staniek
staniek at kde.org
Wed Dec 5 11:03:14 GMT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107598/#review23023
-----------------------------------------------------------
OK, now in the same patch please also add d-pointer to KexiFormScrollView in one go.
- Jarosław Staniek
On Dec. 5, 2012, 10:06 a.m., Shou Ya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107598/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2012, 10:06 a.m.)
>
>
> Review request for Calligra and Jarosław Staniek.
>
>
> Description
> -------
>
> add d-pointer for KexiScrollView.
>
> This is a part of the task 'ADD D-POINTERS TO CLASSES' from Google Code-in(https://www.google-melange.com/gci/task/view/google/gci2012/7971213).
>
> changed KexiScrollView class and some of its derived class KexiFormScrollView who referred to some protected members of KexiScrollView.
>
> So I created some protected assessors for them.
>
>
> Diffs
> -----
>
> kexi/plugins/forms/kexiformscrollview.cpp cad94c7
> kexi/plugins/forms/widgets/kexidbform.h c2e0eca
> kexi/plugins/forms/widgets/kexidbform.cpp c2dd1c5
> kexi/widget/kexiscrollview.h 4fc6f85
> kexi/widget/kexiscrollview.cpp 5a94228
>
> Diff: http://git.reviewboard.kde.org/r/107598/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Shou Ya
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121205/1d00afb8/attachment.htm>
More information about the calligra-devel
mailing list