Review Request: adding d-pointer for kexicharencodingcombobox

[Jarosław Staniek]

> On Dec. 4, 2012, 9:48 p.m., Jarosław Staniek wrote:
> > kexi/widget/kexicharencodingcombobox.cpp, line 120
> > <http://git.reviewboard.kde.org/r/107578/diff/1/?file=97161#file97161line120>
> >
> >     Please always put implementation of Private right after declaration, in this case in line 37.
> 
> Shou Ya wrote:
>     But I don't know how to generate a cross-version patch with git.
>     
>     For example:
>     
>       git history: a -> b -> c
>     
>     It's like; I want to only diff the file changes in version `a' and `c', and generate a patch according that.
>     
>     Thanks.
>

Why don't you want changes 'b' too?


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107578/#review22995
-----------------------------------------------------------


On Dec. 4, 2012, 1:51 p.m., Shou Ya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107578/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2012, 1:51 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> Just adding d-pointer for kexicharencodingcombobox.
> 
> 
> Diffs
> -----
> 
>   kexi/widget/kexicharencodingcombobox.h 74fdfb2 
>   kexi/widget/kexicharencodingcombobox.cpp 4be3315 
> 
> Diff: http://git.reviewboard.kde.org/r/107578/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shou Ya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121205/44d51bd3/attachment.htm>