Review Request: adding d-pointer for kexidbconnectionwidget

Jarosław Staniek staniek at kde.org
Tue Dec 4 21:56:13 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107579/#review22996
-----------------------------------------------------------

Ship it!


Good work, but kexicharencodingcombobox.* files added by accident. I'll commit the kexidbcommectionwidget.* files.


kexi/widget/kexidbconnectionwidget.cpp
<http://git.reviewboard.kde.org/r/107579/#comment17557>

    style: '{' always in a new line for methods


- Jarosław Staniek


On Dec. 4, 2012, 1:54 p.m., Shou Ya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107579/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2012, 1:54 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> adding d-pointer for kexidbconnectionwidget
> 
> 
> Diffs
> -----
> 
>   kexi/widget/kexicharencodingcombobox.h 74fdfb2 
>   kexi/widget/kexicharencodingcombobox.cpp 4be3315 
>   kexi/widget/kexidbconnectionwidget.h 234235a 
>   kexi/widget/kexidbconnectionwidget.cpp 38cd1a2 
> 
> Diff: http://git.reviewboard.kde.org/r/107579/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Shou Ya
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121204/4aa24032/attachment.htm>


More information about the calligra-devel mailing list