Review Request: Implement triple button widget

C. Boemann cbr at boemann.dk
Mon Dec 3 09:49:11 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107530/#review22928
-----------------------------------------------------------


I don't think we want this button to be used here. We should follow the lead of the text tool, where the buttons have become frameless. Also the design work done at Akademy determined that join and cap are rarely used and should be demoted to option menus to save space.

In any case the screenshot was something I asked for privately with Morice, so we could see it in action. Btw, I am working on implementing the design we did at Akademy.

Nevertheless, the triple button on it's own can be useful in dialogs, and so I think it will be a usefull addition to Calligra as a new class regardless if we have a usecase for it right now or not.

But like Thorsten I would like to see the diff. Though I had seen an earlier diff and had comments that I know have been worked on it's always nice to see the final diff.

- C. Boemann


On Dec. 3, 2012, 12:41 a.m., Jean-Nicolas Artaud wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107530/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2012, 12:41 a.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> Implement triple button widget in the calligra widget libs.
> This also can be used for double buttons (like in gwenview for instance).
> 
> 
> Diffs
> -----
> 
>   libs/widgets/KoStrokeConfigWidget.cpp d0a8eb9 
> 
> Diff: http://git.reviewboard.kde.org/r/107530/diff/
> 
> 
> Testing
> -------
> 
> Use the triple button on the property docker.
> 
> 
> Screenshots
> -----------
> 
> Strocke properties docker with the triple buttons
>   http://git.reviewboard.kde.org/r/107530/s/865/
> 
> 
> Thanks,
> 
> Jean-Nicolas Artaud
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121203/e71ebc66/attachment.htm>


More information about the calligra-devel mailing list