Review Request: KexiMainWindow::Private::openedWindowFor(...) moved to public

Jarosław Staniek staniek at kde.org
Sun Dec 2 22:40:33 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107560/#review22921
-----------------------------------------------------------

Ship it!



kexi/main/KexiMainWindow.h
<http://git.reviewboard.kde.org/r/107560/#comment17491>

    Please add /*! Implemented for KexiMainWindowIface. */



kexi/main/KexiMainWindow.cpp
<http://git.reviewboard.kde.org/r/107560/#comment17493>

    return item ? d->openedWindowFor(item->identifier()) : 0;


- Jarosław Staniek


On Dec. 2, 2012, 10:07 p.m., Oleg Kukharchuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107560/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2012, 10:07 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tanis.
> 
> 
> Description
> -------
> 
> would be useful for searching opened window for a given KexiPart::Item
> 
> 
> Diffs
> -----
> 
>   kexi/core/KexiMainWindowIface.h 5b95fe8d4e134517918d869d147ec4615be02ca9 
>   kexi/main/KexiMainWindow.h 591df14013b076bad4f62ac4730a01c8f11a9c19 
>   kexi/main/KexiMainWindow.cpp eb0c0e9a02a3fa459270b1a2ba635134c862df3d 
>   kexi/main/KexiMainWindow_p.h 15f8e569bac40ab1170fb675f94202ed363bf325 
> 
> Diff: http://git.reviewboard.kde.org/r/107560/diff/
> 
> 
> Testing
> -------
> 
> Tested usgin renameObject(...)
> 
> 
> Thanks,
> 
> Oleg Kukharchuk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121202/4ca40314/attachment.htm>


More information about the calligra-devel mailing list