Review Request: Fix next style appears as modified after new line on header style (bug 293378).

Commit Hook null at kde.org
Sat Dec 1 16:41:11 GMT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107540/#review22874
-----------------------------------------------------------


This review has been submitted with commit 863f8e6c080131c34572e6a8ee293c8d19cd1f70 by Pierre Stirnweiss to branch calligra/2.6.

- Commit Hook


On Dec. 1, 2012, 1:29 p.m., Pierre Stirnweiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107540/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2012, 1:29 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> After a list style defining a "next style" (like Head 1), the next style is marked as modified (shows a + button in the combo).
> The problem comes from Qt defining an indent of 1 for list styles. This gets carried over to the block style. Since we do not use Qt's indentation, we need to clear that property.
> 
> Ok to backport to 2.6?
> 
> 
> This addresses bug 293378.
>     http://bugs.kde.org/show_bug.cgi?id=293378
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoList.cpp a9f582b 
>   libs/kotext/styles/KoParagraphStyle.cpp 78f09f0 
> 
> Diff: http://git.reviewboard.kde.org/r/107540/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tried. Seems to work, and I have not spotted regressions.
> 
> 
> Thanks,
> 
> Pierre Stirnweiss
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20121201/cc5289b9/attachment.htm>


More information about the calligra-devel mailing list