Review Request: This increases the flexibility of Statistics Docker Plugin , by allowing it to layout its widgets horizontally when user places it in the bottom area

[Thomas Pfeiffer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106252/#review18340
-----------------------------------------------------------


Looks good now!
If the two issues I opened are either invalid or fixed, I'm happy


Screenshot: The layout
<http://git.reviewboard.kde.org//r/106252/#scomment83>
    Is it just the screenshot or does the icon have something other than the wrench in it near the bottom)? If it does, it's the wrong icon. The one I meant only has the wrench in it.


Screenshot: The layout
<http://git.reviewboard.kde.org//r/106252/#scomment84>
    Do the horizontal spacers between the different statistics adjust with the docker's width?
    If they are fixed, please make them dynamic. If they are already dynamic, ignore this comment.

- Thomas Pfeiffer


On Aug. 31, 2012, 12:19 p.m., Shreya Pandit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106252/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2012, 12:19 p.m.)
> 
> 
> Review request for Calligra, Thomas Pfeiffer and Inge Wallin.
> 
> 
> Description
> -------
> 
> This allows the Statistics Docker to update its layout horizontally, when placed in bottom area. 
> 
> 
> Diffs
> -----
> 
>   words/part/dockers/KWStatistics.h c480502 
>   words/part/dockers/KWStatistics.cpp a006d97 
>   words/part/dockers/KWStatisticsDocker.h fab6c7f 
>   words/part/dockers/KWStatisticsDocker.cpp 0bc8130 
>   words/part/dockers/KWStatisticsDocker.ui 63eaee5 
>   words/part/dockers/StatisticsPreferencesPopup.h b481806 
>   words/part/dockers/StatisticsPreferencesPopup.cpp c741622 
> 
> Diff: http://git.reviewboard.kde.org/r/106252/diff/
> 
> 
> Testing
> -------
> 
> Checked for calligra words and calligra author
> 
> 
> Screenshots
> -----------
> 
> The layout
>   http://git.reviewboard.kde.org/r/106252/s/713/
> 
> 
> Thanks,
> 
> Shreya Pandit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120831/ed70958c/attachment.htm>