Review Request: Fix deform brush

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106222/#review18289
-----------------------------------------------------------


This review has been submitted with commit 7e499ddf9bcae682369a2395a6be6bb1e5d02e2a by Lukáš Tvrdý to branch master.

- Commit Hook


On Aug. 26, 2012, 6:20 p.m., Lukáš Tvrdý wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106222/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2012, 6:20 p.m.)
> 
> 
> Review request for Calligra, Cyrille Berger Skott, Boudewijn Rempt, Dmitry Kazakov, and Sven Langkamp.
> 
> 
> Description
> -------
> 
> Deform brush was not usable after regression from the port to NG-iterators.
> KisRandomSubAccessor did not provide rawData() (pixels "as they are" in transaction opposed to oldRawData() which refers to pixel status before transaction/change)
> 
> KisRandomSubAccessor uses KisRandomAccessorNG now instead of KisRandomConstAccessorNG. KisRandomAccessorNG provides rawData() which are needed in use-cases like deform brush.
> 
> My question is (probably for Dmitry) if KisRandomAccessorNG::oldRawData() and KisRandomConstAccessorNG::oldRawData() provides the same data? 
> Is the semantics the same? What is the purpose of the difference?
> 
> Is it ok to backport to 2.5?
> 
> 
> This addresses bug 299701.
>     http://bugs.kde.org/show_bug.cgi?id=299701
> 
> 
> Diffs
> -----
> 
>   krita/image/kis_random_sub_accessor.h 6950d97 
>   krita/image/kis_random_sub_accessor.cpp 4a978d1 
>   krita/plugins/paintops/deform/deform_brush.cpp 643e5a0 
> 
> Diff: http://git.reviewboard.kde.org/r/106222/diff/
> 
> 
> Testing
> -------
> 
> I tested clients of KisRandomSubAccessor:
> spray, deform, duplicate, grid and they work as expected
> 
> I would like to ask users to test:
> wave filter : I tested it, but I'm not sure if the result is correct, it looks ok to me: Filters->Other->Wave
> kis_warptransform_worker (Warp mode in transform tool I think)
> kis_perspectivetransform_worker (Perspective mode in transform tool I think)
> 
> They all depends on correct behaviour of oldRawData so there should be no regressions.
> 
> 
> Thanks,
> 
> Lukáš Tvrdý
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120830/c2004f07/attachment.htm>