Review Request: Enabling Sheets to show plugin items on Configure Sheets/Plugins page

[Marijn Kruisselbrink]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106220/#review18119
-----------------------------------------------------------

Ship it!


Looks good to me

- Marijn Kruisselbrink


On Aug. 26, 2012, 2:23 p.m., Yuri Chornoivan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106220/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2012, 2:23 p.m.)
> 
> 
> Review request for Calligra and Marijn Kruisselbrink.
> 
> 
> Description
> -------
> 
> Plugins page in settings dialog is empty in the current versions of Calligra Sheets (2.5 and git/master).
> 
> As there have been a need for some plugin items for a documentation screenshot, it was reasonable to enable some plugins by fixing KSpread leftovers.
> 
> 
> This addresses bug 291343.
>     http://bugs.kde.org/show_bug.cgi?id=291343
> 
> 
> Diffs
> -----
> 
>   sheets/part/ToolRegistry.cpp bdbac72 
>   sheets/part/dialogs/PreferenceDialog.cpp 4856dad 
>   sheets/plugins/calendar/kspread_plugin_tool_calendar.desktop 4810eec 
> 
> Diff: http://git.reviewboard.kde.org/r/106220/diff/
> 
> 
> Testing
> -------
> 
> The items for function plugins appear in the list. However, it seems that some issues left. Console shows the messages like
> 
> plugins should not have a 'lib' prefix: "libkspreadsolver.so"
> kdecore (KPluginInfo): found 0 offers for "InformationModule"
> 
> Do not know if these are critical.
> 
> 
> Thanks,
> 
> Yuri Chornoivan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120827/9f681375/attachment.htm>