Review Request: Load fo:margin and fo:padding shorthands before the left/right/top/bottom variants

Inge Wallin inge at lysator.liu.se
Sun Aug 26 14:52:56 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106214/#review18035
-----------------------------------------------------------

Ship it!


Looks good.

- Inge Wallin


On Aug. 26, 2012, 1:05 p.m., Elvis Stansvik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106214/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2012, 1:05 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> The left/right/top/bottom variants are more specific and should override the fo:margin/fo:padding shorthands. This is in line with how LO/AOO does it.
> 
> 
> Diffs
> -----
> 
>   libs/kotext/styles/KoParagraphStyle.cpp 6a5b498 
> 
> Diff: http://git.reviewboard.kde.org/r/106214/diff/
> 
> 
> Testing
> -------
> 
> Ran unit tests.
> 
> 
> Thanks,
> 
> Elvis Stansvik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120826/5a8a8bb7/attachment.htm>


More information about the calligra-devel mailing list