Review Request: remove deprecated and unused many-arguments constructor of KoUnitDoubleSpinBox

C. Boemann cbr at boemann.dk
Fri Aug 24 18:56:31 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106168/#review17964
-----------------------------------------------------------

Ship it!


yes it's bad api design

- C. Boemann


On Aug. 24, 2012, 5:45 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106168/
> -----------------------------------------------------------
> 
> (Updated Aug. 24, 2012, 5:45 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Came across this constructor, it should be reliefed to Code Valhalla, no longer any enemies^Wclients for it.
> 
> 
> Diffs
> -----
> 
>   libs/widgets/KoUnitDoubleSpinBox.h 959e57e 
>   libs/widgets/KoUnitDoubleSpinBox.cpp 351c698 
> 
> Diff: http://git.reviewboard.kde.org/r/106168/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120824/2d85745d/attachment.htm>


More information about the calligra-devel mailing list