[REVIEW REQUEST] Cleanup of unused or duplicated icons

Friedrich W. H. Kossebau kossebau at kde.org
Wed Aug 22 20:19:05 BST 2012


Am Donnerstag, 16. August 2012, 18:55:12 schrieb C. Boemann:
> On Thursday 16 August 2012 18:49:22 Friedrich W. H. Kossebau wrote:
> > Am Donnerstag, 16. August 2012, 18:37:13 schrieb C. Boemann:
> > > On Thursday 16 August 2012 16:38:55 Dag wrote:
> > > > Torsdag den 16. august 2012 16:19:29 Friedrich W. H. Kossebau skrev:
> > > > > I would say it is a misinformation, as Calligra depends on kdelibs
> > > > > (4.3),
> > > > > so indirectly depends on the Oxygen icon set (from 4.3). And there
> > > > > would be lots of "unknown" icons in the Calligra UI if Oxygen was
> > > > > not present, not only by what kdelibs uses.
> > > > > 
> > > > > I guess having icon copies was only needed with kolibs, right?
> > > > 
> > > > Eehh, don't really know the reason.
> > > 
> > > Well even though we install the oxygen icons because we depend on it,
> > > does not mean the user has the oxygen icon set selected. That other icon
> > > set will probably not have all needed icons, and that is why we need to
> > > provide the fallback icons aka hi color
> > 
> > AFAIK Oxygen icon set is the default fallback icon set with kdelibs. So if
> > a user selects another icon set, for any not found icons in there
> > KIconLoader will as last ressort pick the one from Oxygen.
> > That is why the Oxygen icon set is a hard dependency for kdelibs.
> > 
> > Otherwise Calligra would need to ship a complete set of all Oxygen icons
> > it
> > (and the used kdelibs parts) uses, as any icon might miss from the other
> > icon set.
> > 
> > So if there is kdelibs, there is also Oxygen icon set in the background.
> > 
> > Cheers
> > Friedrich
> 
> Oh that would be really nice if it is so. Can we find out somehow?

For kde-runtime 4.9 and master the runtime dependency on Oxygen Icons is even 
officially declared now, see
http://commits.kde.org/kde-runtime/3640d24eb19c84c4fb9b81aa351025810a01f132
http://commits.kde.org/kde-runtime/cc35c94793c9eb4e6184b033ef60fda161689836
after discussion on ml release-team.

:)

Cheers
Friedrich



More information about the calligra-devel mailing list