warning: overflow in implicit constant conversion in KoShape.cpp

[André Wöbbeking]

Hi,

when compiling Calligra I get:

calligra/libs/flake/KoShape.cpp: In constructor 'KoShapePrivate::KoShapePrivate(KoShape*)':
calligra/libs/flake/KoShape.cpp:105:48: warning: overflow in implicit constant conversion [-Woverflow]
calligra/libs/flake/KoShape.cpp:105:48: warning: overflow in implicit constant conversion [-Woverflow]
calligra/libs/flake/KoShape.cpp:105:48: warning: overflow in implicit constant conversion [-Woverflow]
calligra/libs/flake/KoShape.cpp: In member function 'void KoShape::copySettings(const KoShape*)':
calligra/libs/flake/KoShape.cpp:668:24: warning: overflow in implicit constant conversion [-Woverflow]

This is caused by bit fiddling in KoShape_p.h where int : 1 is used for bools.
IMO this should be changed to uint : 1 like Qt is doing it to be more portable.


Cheers,
André


P.S.: Please CC me.