Review Request: remove deprecated and unneeded setting of spacings/margins using KDialog::*Hint()

Friedrich W. H. Kossebau kossebau at kde.org
Sat Aug 18 16:46:08 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106078/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

KDialog::marginHint() and KDialog::spacingHint() are left-overs from KDE3 times, no more need to explicitely set the margins/spacing using these methods.

Did not mess around with Kexi code, as I do not have a complete picture of its custom layouting and it might rely on the values as returned from both methods.


Diffs
-----

  filters/libdialogfilter/exportsizedia.cpp 6fe5fde 
  krita/ui/dialogs/kis_dlg_preferences.cc 1bf890d 
  libs/main/KoExistingDocumentPane.cpp 85e6d5f 
  libs/main/KoVersionDialog.cpp 361886d 
  libs/main/config/KoConfigDocumentPage.cpp 7755a2a 
  libs/main/config/KoConfigGridPage.cpp 356d5e8 
  libs/main/config/KoConfigMiscPage.cpp dfb922e 
  libs/widgets/KoColorSetWidget.cpp c50ab77 
  plugins/textediting/thesaurus/Thesaurus.cpp 5bf6269 
  sheets/dialogs/AngleDialog.cpp ea33eda 
  sheets/dialogs/AutoFormatDialog.cpp 4f4c2f0 
  sheets/dialogs/CharacterSelectDialog.cpp ce5e62b 
  sheets/dialogs/CommentDialog.cpp c511cb4 
  sheets/dialogs/FormulaDialog.cpp 783ab1a 
  sheets/dialogs/GotoDialog.cpp b948199 
  sheets/dialogs/InsertDialog.cpp 16e5e4c 
  sheets/dialogs/LayoutDialog.cpp 673614f 
  sheets/dialogs/ListDialog.cpp 477e015 
  sheets/dialogs/NamedAreaDialog.cpp 9d38cb2 
  sheets/dialogs/PasteInsertDialog.cpp 5f28a8f 
  sheets/dialogs/SeriesDialog.cpp 1e711fb 
  sheets/dialogs/ShowColRowDialog.cpp 3eb8265 
  sheets/dialogs/ShowDialog.cpp b223963 
  sheets/dialogs/ValidityDialog.cpp fd643aa 
  sheets/tests/inspector.cpp c20cfca 

Diff: http://git.reviewboard.kde.org/r/106078/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120818/df96dd91/attachment.htm>


More information about the calligra-devel mailing list