Review Request: Introduce Author into the Calligra family

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106064/#review17643
-----------------------------------------------------------



words/part/author/CAuAboutData.h
<http://git.reviewboard.kde.org/r/106064/#comment13808>

    Co-maintainer



words/part/author/CAuAboutData.h
<http://git.reviewboard.kde.org/r/106064/#comment13807>

    Co-maintainer



words/part/author/CAuPart.h
<http://git.reviewboard.kde.org/r/106064/#comment13809>

    Size dox comments should use ///< or //!< otherwise the comment will be applied to the subsequent lines of code.
    
    Info: http://www.stack.nl/~dimitri/doxygen/docblocks.html#memberdoc
    



words/part/author/main.cpp
<http://git.reviewboard.kde.org/r/106064/#comment13811>

    Why to hardcode it here? No other app, despote potential gains, do that in Calligra. You may want to put an advice (to use command line switch for calligraauthor) on the community.kde.org for Author if there's specific need like this. 
    



words/part/author/main.cpp
<http://git.reviewboard.kde.org/r/106064/#comment13814>

    Please use return app.exec();



words/part/author/main.cpp
<http://git.reviewboard.kde.org/r/106064/#comment13813>

    This will not be needed if you put   aboutData in line 27 to QScopedPointer.
    This way you'll also remove memory leak that appears on line 43.


- Jarosław Staniek


On Aug. 17, 2012, 8:46 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106064/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2012, 8:46 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This is the first step in realizing [1]. Currently author resides in words/part and will eventually moved out to a directory of its own. This patch is currently a work in progress and to evaluate that we are on the right path.
> 
> Currently there is a known issue that various options of the text tool are not shown for the first time when the application is launched(see attached snapshot). Once I explicitly activate the tool by switching to a different tool and back it works fine. Any ideas what can be wrong? 
> 
> 
> [1] http://www.calligra.org/news/calligra-announces-author/
> 
> 
> Diffs
> -----
> 
>   words/part/CMakeLists.txt cdeca2b 
>   words/part/KWPart.h 5b6621b 
>   words/part/KWPart.cpp f94354a 
>   words/part/author/CAuAboutData.h PRE-CREATION 
>   words/part/author/CAuFactory.h PRE-CREATION 
>   words/part/author/CAuFactory.cpp PRE-CREATION 
>   words/part/author/CAuFactoryInit.cpp PRE-CREATION 
>   words/part/author/CAuPart.h PRE-CREATION 
>   words/part/author/CAuPart.cpp PRE-CREATION 
>   words/part/author/CAuView.h PRE-CREATION 
>   words/part/author/CAuView.cpp PRE-CREATION 
>   words/part/author/author.desktop PRE-CREATION 
>   words/part/author/author.rc PRE-CREATION 
>   words/part/author/author_readonly.rc PRE-CREATION 
>   words/part/author/authorpart.desktop PRE-CREATION 
>   words/part/author/authorrc PRE-CREATION 
>   words/part/author/main.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106064/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Text Tool
>   http://git.reviewboard.kde.org/r/106064/s/678/
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120818/a5b7146c/attachment.htm>