[REVIEW REQUEST] Cleanup of unused or duplicated icons
    Friedrich W. H. Kossebau 
    kossebau at kde.org
       
    Thu Aug 16 06:59:07 BST 2012
    
    
  
Hi,
looking for icons which are not needed in the current Calligra codebase I 
collected quite a few. So below find a list of icon files in Calligra which 
are either duplicates of icons in Oxygen (as part of KDE 4.3.5) or not used by 
any code, as far as I can tell. I skipped a few icon files, as I am not too 
sure about Kexi and Krita code (and possible hidden icon references), but 
these here should be safe, and are a good start.
I guess putting this on review board does not work nicely (or?), so please 
review the list of icons to remove here and give an okay to commit to master.
DUPLICATED ICONS (Oxygen 4.3.5)
pics/hicolor/hi*-action-format-font-size-{less,more}.png
used by sheets/ui/CellToolBase.cpp
pics/hicolor/hi*-action-format-line-spacing-{normal,double,triple}.png
not used by anything
there is libs/koreport/pics/hicolor/hi*-action-checkbox.png
used in libs/koreport/items/check/KoReportCheckPlugin.cpp
libs/flake/pics/ox*-action-snap-{extension,intersection,guideline,node,orto}.
{png,svg}
only the new boundingbox is needed, because not part of Oxygen set
pics/hicolor/hi*-action-view-sort-{ascending,descending}.png
used in sheets/ui/CellToolBase.cpp, sheets/dialogs/SortDialog.cpp, 
kexi/core/KexiStandardAction.cpp
plan/toolbar/hi32-action-view{,-add}.png
used in plan/kptview.cpp, plan/libs/ui/kptdependencyeditor.cpp, 
plan/libs/ui/kpttaskeditor.cpp
not present in Oxygen is view-child-add, instead there is view-child
plan/toolbar/hi32-action-resource-calendar-(child-)insert.png
used in plan/libs/ui/kptcalendareditor.cpp
plan/toolbar/hi22-action-resource-group-new.png
used in plan/libs/ui/kptresourceeditor.cpp
plan/toolbar/hi22-action-view-time-schedule-{edit,calculus,child-
insert,baselined,baselined-add,baselined-remove}.png
used in plan/kptview.cpp, plan/libs/ui/kptscheduleeditor.cpp, 
plan/libs/models/kptschedulemodel.cpp
NOT USED AT ALL:
./pics/hicolor/hi*-action-borderoutline.png
./pics/hicolor/hi22-action-borderbottom.png
./pics/hicolor/hi22-action-bordertop.png
./pics/hicolor/hi22-action-borderright.png
./pics/hicolor/hi22-action-borderleft.png
./pics/hicolor/hi*-action-bring_forward.*
./pics/hicolor/hi*-action-send_backward.png
./pics/hicolor/hi22-action-delslide.png
./pics/hicolor/hi22-action-slide-new.png
./pics/hicolor/hi22-action-slide.png
./pics/hicolor/hi16-action-tab_*.png
./pics/hicolor/hi*-app-go.png
./pics/hicolor/hi22-action-group.png
./pics/hicolor/hi22-action-ungroup.png
./pics/hicolor/hi16-action-view_split.png
./pics/hicolor/hi16-action-view_orientation.png
./pics/hicolor/hi16-action-textcolor.png
./pics/hicolor/hi22-action-aocenterh.png
./pics/hicolor/hi22-action-aocenterv.png
./pics/hicolor/hi22-action-clipart.png
./pics/hicolor/hi22-action-clipart_from_file.png
./pics/hicolor/hi*-action-color_fill.png
./pics/hicolor/hi*-action-color_line.png
./pics/oxygen/ox32-mimetype-x-shape-chart.png (chart(-tool) factories use 
kchart)
./pics/hicolor/hi*-action-delete_table_row.png (kexi has its own special 
delete_table_row)
./pics/hicolor/hi*-action-delete_table_col.png 
./pics/hicolor/hi*-action-insert_table_col.png
./libs/widgets/pics/hi22-action-zoom-width.png
./libs/widgets/pics/hi22-action-zoom-page.png
./plugins/textshape/pics/hi22-action-kotext-character.png
./plugins/textshape/pics/hi22-action-kotext-paragraph.png
./plugins/defaultTools/pics/rotate.png
./plugins/defaultTools/pics/shear.png
./plugins/textshape/pics/hi16-action-tool-paragraph.png
./braindump/data/import/zoom-page.png
./braindump/data/import/zoom-width.png
./krita/pics/deletelayer.png
./krita/pics/raiselayer.png
./krita/pics/lowerlayer.png
./plan/workpackage/pics/hi45-mimetypes-application-x-vnd.kde.plan.work.png
./plan/toolbar/hi22-action-accounts.png
./karbon/pics/action/hi22-action-style_*.png
./kexi/pics/hi16-action-select_item.png
./sheets/data/toolbar/hicolor/hi16-action-inserttable.png
./sheets/data/toolbar/hicolor/hi*-action-sort_decrease.png
./sheets/data/toolbar/hicolor/hi*-action-sort_incr.png
./words/toolbar/hi22-action-sl_*.png
Cheers
Friedrich
    
    
More information about the calligra-devel
mailing list