Review Request: Main Window: Workaround for visual glitch of Oxygen style for menu widget

[Adam Pigg]

> On Aug. 15, 2012, 8:40 p.m., Adam Pigg wrote:
> > kexi/main/KexiMainWindow_p.h, line 256
> > <http://git.reviewboard.kde.org/r/105996/diff/1/?file=77292#file77292line256>
> >
> >     how about using 0.91208792 ?? :D  What is this number?
> 
> Jarosław Staniek wrote:
>     I knew you're curious. There are some algorithms in Oxygen to make color a bit lighter. They are not in the public API nor they are simple. So the number was computed by me to find the proper value for the color (accuracy is quite OK). 
>     
>     It's also related to the fact that Oxygen's menus have gradient background. A lot of computation happens under the mask...

could the code be disabled for newer kde versions that dont exhibit this problem?  Ive never seen it in kde 4.8 or 4.9.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105996/#review17483
-----------------------------------------------------------


On Aug. 12, 2012, 10:34 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105996/
> -----------------------------------------------------------
> 
> (Updated Aug. 12, 2012, 10:34 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> Main Window: Workaround for visual glitch of Oxygen style for menu widget
> 
> 
> This addresses bug 305051.
>     http://bugs.kde.org/show_bug.cgi?id=305051
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow_p.h 07f3c69705612ffdccfa1392be242194ab3445f6 
> 
> Diff: http://git.reviewboard.kde.org/r/105996/diff/
> 
> 
> Testing
> -------
> 
> Tested on various color schemes
> 
> 
> Screenshots
> -----------
> 
> Visual glitch
>   http://git.reviewboard.kde.org/r/105996/s/673/
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120815/e09c0893/attachment.htm>