Review Request: use KGlobalSettings::smallestReadableFont() in ruler (and remove hardcoding size to 6pt)

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106040/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

Somehow the numbers in the rulers to me still looked not balanced to the rest of the UI. Having a closer look at the code I found that the basic reason is that while the ruler metric calculations are based on KGlobalSettings::toolBarFont() the actual rendering does use the normal widget font.

Another issue I see is that KGlobalSettings::toolBarFont() is used, not KGlobalSettings::smallestReadableFont(), which IMHO is better suited here. And the API dox writer even agrees with me:
http://api.kde.org/4.8-api/kdelibs-apidocs/kdeui/html/classKGlobalSettings.html#a1af6d9cc0108fca58b002b4c127dc51f
"This can be used in dockers, rulers and other places where space is at a premium."
:)

Attached patch fixes that, both by switching to smallestReadableFont() and setting the font before rendering the measurement numbers.

Okay to backport to 2.5?


Diffs
-----

  libs/main/KoRuler.cpp 98b096a 

Diff: http://git.reviewboard.kde.org/r/106040/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120815/7b8d54a9/attachment.htm>