Review Request: fix KisPaintOpPresetsPopup to use an existing icon for the paintPresetIcon button

[Friedrich W. H. Kossebau]

> On July 23, 2012, 7:50 a.m., Boudewijn Rempt wrote:
> > I'm actually totally unsure what this button does... I'm not even sure it's actually visible.
> 
> Friedrich W. H. Kossebau wrote:
>     I can now help you (had to hunt down where it is as well :) )
>     
>     In the Krita toolbar click the "Edit brush settings" popup button, then look at the four buttons below the brush testing area on the right side, it's the very left of them. Pressing the button will paint the icon of the preset in big onto the brush testing area.
>

Not visible? Hehe, this missing icon is now even prominently visible in the Krita 2.5 release news :)
See in the second screenshot the fourth button from the right at the bottom ( http://www.krita.org/images/texture_option.jpg )

So, what would be the best fix here?
Okay with "krita_tool_freehand" and a "TODO: proper icon needed", both master and 2.5?


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105669/#review16261
-----------------------------------------------------------


On July 22, 2012, 3:48 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105669/
> -----------------------------------------------------------
> 
> (Updated July 22, 2012, 3:48 p.m.)
> 
> 
> Review request for Calligra and Boudewijn Rempt.
> 
> 
> Description
> -------
> 
> There is no "krita_paintop_icon" icon.
> From the existing icons "krita_tool_freehand" might come closest, so proposing to use that as substitute in this patch, arguing that the usual preset icon/preview is also some sketched freehand lines, so this icon can serve as a working symbol.
> 
> Okay to backport to 2.5?
> 
> 
> Diffs
> -----
> 
>   krita/ui/widgets/kis_paintop_presets_popup.cpp 38e5d8a 
> 
> Diff: http://git.reviewboard.kde.org/r/105669/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120814/1981e9dc/attachment.htm>