Review Request: Fix for artifacts in the path point handles

Commit Hook null at kde.org
Mon Aug 13 16:57:16 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105834/#review17325
-----------------------------------------------------------


This review has been submitted with commit 5efce93312a466b95c7fb9ceb6c3795974377791 by Sven Langkamp to branch calligra/2.5.

- Commit Hook


On Aug. 3, 2012, 12:59 a.m., Sven Langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105834/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2012, 12:59 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> When editing a path in Krita the path tool causes some artifacts. See attached screenshot. The problem is that the handles only update the current position of the handle, but not the previous. The patch keeps the previous rect to update it in the next update. It's a bit ugly, but I didn't find a better fix.
> 
> 
> Diffs
> -----
> 
>   libs/flake/tools/KoPathToolHandle.h 796667f 
>   libs/flake/tools/KoPathToolHandle.cpp e37a7a7 
> 
> Diff: http://git.reviewboard.kde.org/r/105834/diff/
> 
> 
> Testing
> -------
> 
> Tested in Krita, solves the artifacts problem.
> 
> 
> Screenshots
> -----------
> 
> Artifacts
>   http://git.reviewboard.kde.org/r/105834/s/662/
> 
> 
> Thanks,
> 
> Sven Langkamp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120813/26f513bb/attachment.htm>


More information about the calligra-devel mailing list