Review Request: support rendering of separators of text columns

Friedrich W. H. Kossebau kossebau at kde.org
Sat Aug 11 00:52:03 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105975/
-----------------------------------------------------------

Review request for Calligra and C. Boemann.


Description
-------

I had the idea to render the column separators using the background shapes. What do you think? Would that be alright at least as a temporary solution?

Patch also fixes page background ignoring the margins. At least LO/AOO does not paint the background in the margin. Sadly the attribute "draw:background-size" is not available for <style:page-layout-properties>, only for <style:drawing-page-properties>. Filed a complain on the office-comment mailinglist.
    
And patch removes redundant setting of background to frame shapes in KWTextFrameSet::setPageStyle(...).

Okay to backport to 2.5?


Diffs
-----

  words/part/frames/KWFrameLayout.cpp d9675b0 
  words/part/frames/KWTextFrameSet.cpp 7afa7bf 

Diff: http://git.reviewboard.kde.org/r/105975/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120810/47fac1e4/attachment.htm>


More information about the calligra-devel mailing list