Review Request: CSV Import: Import last line even if it is only ""

Adam Pigg adam at piggz.co.uk
Fri Aug 10 14:24:15 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105950/#review17190
-----------------------------------------------------------

Ship it!


Ship It!

- Adam Pigg


On Aug. 9, 2012, 10:08 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105950/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 10:08 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> CSV Import: Import last line even if it is only ""
> 
> 
> This addresses bug 304891.
>     http://bugs.kde.org/show_bug.cgi?id=304891
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 51340273b65e7f4a1b3038c578aa7b927e90436c 
> 
> Diff: http://git.reviewboard.kde.org/r/105950/diff/
> 
> 
> Testing
> -------
> 
> Test file attached in the bug report is imported as expected
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120810/f1fca23b/attachment.htm>


More information about the calligra-devel mailing list