Review Request: Fix crash on importing CSV files with more than 1024 columns

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105844/#review17082
-----------------------------------------------------------



kexi/plugins/importexport/csv/kexicsvimportdialog.h
<http://git.reviewboard.kde.org/r/105844/#comment13385>

    This comment at line 196 is outdated; we use _*_TYPE constants. We can indeed switch to KexiDB::Field::Type everywhere, this will be part of another patch.


- Jarosław Staniek


On Aug. 3, 2012, 10:29 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105844/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2012, 10:29 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg, Dimitrios Tanis, and Oleg Kukharchuk.
> 
> 
> Description
> -------
> 
> Fix crash on importing CSV files with more than 1024 columns
> 
> 
> This addresses bug 304405.
>     http://bugs.kde.org/show_bug.cgi?id=304405
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.h e329c5235c11e416d23d68589813c6631b472d35 
>   kexi/plugins/importexport/csv/kexicsvimportdialog.cpp 751fb7de67d1cab4e95506cf6a37342075b660f9 
> 
> Diff: http://git.reviewboard.kde.org/r/105844/diff/
> 
> 
> Testing
> -------
> 
> Imports test data properly
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120807/bf90a356/attachment.htm>