Review Request: install SVM data in mimetype database; use same mimetype for SVM like LO/AOO: "image/x-svm"

[Friedrich W. H. Kossebau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105883/
-----------------------------------------------------------

Review request for Calligra, Thorsten Zachmann and Inge Wallin.


Description
-------

Triggered by "Fix loading of VectorShape and KoUnavailShape." (https://git.reviewboard.kde.org/r/105873/) I had another look at the mimetype and detection of SVM files. And found e.g. these, among a lot of similar matches:
* http://api.libreoffice.org/common/ref/com/sun/star/graphic/MediaProperties.html
* https://svn.apache.org/repos/asf/incubator/ooo/trunk/main/filter/source/config/fragments/types/svm_StarView_Metafile.xcu

So it seems that "image/x-svm" is the internally used mimetype string, not "application/x-svm". While that one is not used in the manifest by LO (correctly, as I understood the package spec), Calligra better still should switch to use it internally as well.

And installing the magic data about SVM into the mimetype database will result both in KoOdfLoadingContext::mimeTypeForPath(const QString& path, bool guess) with guess=true delivering the proper mimetype (no longer application/octet-stream), as well as allow to use the mimetype also in the filedialogs to chose a file for the vector shape.


Diffs
-----

  plugins/vectorshape/CMakeLists.txt fe677e5 
  plugins/vectorshape/VectorShape.cpp 232402a 
  plugins/vectorshape/VectorShapeConfigWidget.cpp ca9f743 
  plugins/vectorshape/VectorShapeFactory.cpp fd04aac 
  plugins/vectorshape/VectorTool.cpp 2cbe9db 
  plugins/vectorshape/calligra_svm.xml PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/105883/diff/


Testing
-------


Thanks,

Friedrich W. H. Kossebau

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120805/9792c214/attachment.htm>