Review Request: Add support for EPUB 2.0.1

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105820/#review16872
-----------------------------------------------------------



filters/words/epub/exportepub2.cpp
<http://git.reviewboard.kde.org/r/105820/#comment13199>

    I know it is only a debug but using stl like iteraters make this much faster instead of lookinging up the style every time by value.



filters/words/epub/exportepub2.cpp
<http://git.reviewboard.kde.org/r/105820/#comment13197>

    The odfStore and the styles in styles are not deleted. Please free all dynamically allocated data.



filters/words/epub/exportepub2.cpp
<http://git.reviewboard.kde.org/r/105820/#comment13198>

    Please move head and attributeList into the foreach loop then the clear at the end of the loop is not needed.



filters/words/epub/exportepub2.cpp
<http://git.reviewboard.kde.org/r/105820/#comment13200>

    There should be a blank before and after the +



filters/words/epub/exportepub2.cpp
<http://git.reviewboard.kde.org/r/105820/#comment13201>

    In case there is an error the odfStore is not closed.



filters/words/epub/htmlconvert.h
<http://git.reviewboard.kde.org/r/105820/#comment13202>

    Please remove the spaces after the types



filters/words/epub/htmlconvert.h
<http://git.reviewboard.kde.org/r/105820/#comment13203>

    These functions should be put at least into a namespace.



filters/words/epub/htmlconvert.cpp
<http://git.reviewboard.kde.org/r/105820/#comment13204>

    No need to close the store when open failed.



filters/words/epub/htmlconvert.cpp
<http://git.reviewboard.kde.org/r/105820/#comment13205>

    The store should be closed in case there was an error.
    



filters/words/epub/htmlconvert.cpp
<http://git.reviewboard.kde.org/r/105820/#comment13206>

    The store should be closed in case there was an error.



filters/words/epub/htmlconvert.cpp
<http://git.reviewboard.kde.org/r/105820/#comment13207>

    These should be moved into the forEachElement loop as then the clear at the end is not needed.



filters/words/epub/htmlconvert.cpp
<http://git.reviewboard.kde.org/r/105820/#comment13208>

    Why not remove the temp variable attribute? it just will exectue unneeded code.



filters/words/epub/htmlconvert.cpp
<http://git.reviewboard.kde.org/r/105820/#comment13209>

    please declare when first used.



filters/words/epub/htmlconvert.cpp
<http://git.reviewboard.kde.org/r/105820/#comment13210>

    The store should be closed here.



filters/words/epub/htmlconvert.cpp
<http://git.reviewboard.kde.org/r/105820/#comment13211>

    The comment seems to be no longer needed.


- Thorsten Zachmann


On Aug. 4, 2012, 3:11 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105820/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2012, 3:11 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> This patch adds support for EPUB 2.0.1, the standard format for ebooks. The current standard is version 3.0 but that is a much more extensive standard and we have to start somewhere.
> 
> Features:
>  - Text with extensive formatting
>  - Tables, even tables in tables
>  - Pictures
>  - Breaking into different html files (chapters) by having a break-before on a paragraph style.
> 
> The support is of course not perfect yet but the current state seems to be useful and it looks like a good point to get it to master so that more people can help out. 
> 
> 
> Diffs
> -----
> 
>   filters/words/CMakeLists.txt a07793a 
>   filters/words/epub/CMakeLists.txt PRE-CREATION 
>   filters/words/epub/TODO PRE-CREATION 
>   filters/words/epub/exportepub2.h PRE-CREATION 
>   filters/words/epub/exportepub2.cpp PRE-CREATION 
>   filters/words/epub/htmlconvert.h PRE-CREATION 
>   filters/words/epub/htmlconvert.cpp PRE-CREATION 
>   filters/words/epub/libepub/EpubFile.h PRE-CREATION 
>   filters/words/epub/libepub/EpubFile.cpp PRE-CREATION 
>   filters/words/epub/words_epub2_export.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/105820/diff/
> 
> 
> Testing
> -------
> 
> We have a number of test files and the attached file contains all the features that are supported. We have also used the EPUB validator a lot. That can be found at http://validator.idpf.org/. 
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120804/bba5ad4c/attachment.htm>