Review Request: Fix Bug 299112 - Roundtripping of lists with image bullets

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104795/#review13146
-----------------------------------------------------------



libs/flake/KoImageCollection.h
<http://git.reviewboard.kde.org/r/104795/#comment10253>

    hmm looks wrong, if you already have an instance why would you want to create a new one only to get the same returned



libs/flake/KoImageCollection.cpp
<http://git.reviewboard.kde.org/r/104795/#comment10254>

    the code inside the if should never be executed if "data" was created correctly in the first place



libs/flake/KoShapeSavingContext.cpp
<http://git.reviewboard.kde.org/r/104795/#comment10251>

    this looks wrong, there should only be one image collection per document, and here you are creating a private one?



libs/kotext/styles/KoListLevelProperties.cpp
<http://git.reviewboard.kde.org/r/104795/#comment10252>

    just curious: what is the reason for this move. We should save attributes in the order specified in schema. Not sure we did that before either.


- C. Boemann


On April 30, 2012, 3:06 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104795/
> -----------------------------------------------------------
> 
> (Updated April 30, 2012, 3:06 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> The roundtripping for the document attached to the bug report fails currently. This patch fixes the issue.
> 
> 
> This addresses bug 299112.
>     http://bugs.kde.org/show_bug.cgi?id=299112
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoImageCollection.h d0b1b64 
>   libs/flake/KoImageCollection.cpp 2965dd6 
>   libs/flake/KoShapeSavingContext.h 4801b29 
>   libs/flake/KoShapeSavingContext.cpp 34e729e 
>   libs/kotext/opendocument/KoTextWriter_p.h 3f51ea6 
>   libs/kotext/styles/KoListLevelProperties.cpp f3dd4ff 
> 
> Diff: http://git.reviewboard.kde.org/r/104795/diff/
> 
> 
> Testing
> -------
> 
> Checked roundtripping with the document attached to the bug
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120430/2fe5380a/attachment.htm>