Review Request: Text dragging in the textshapes

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104773/#review13045
-----------------------------------------------------------


The code looks quite good besides the few points I added. I have not yet tested the code as I need to finish some other stuff before I can test


libs/flake/KoToolProxy.cpp
<http://git.reviewboard.kde.org/r/104773/#comment10151>

    Please revert this change as now the supported paste mime types is always a empty list.



libs/kotext/KoTextEditor.h
<http://git.reviewboard.kde.org/r/104773/#comment10152>

    Please remove the additional space



plugins/textshape/TextTool.cpp
<http://git.reviewboard.kde.org/r/104773/#comment10153>

    Please remove the qDebug


- Thorsten Zachmann


On April 28, 2012, 5:03 p.m., C. Boemann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104773/
> -----------------------------------------------------------
> 
> (Updated April 28, 2012, 5:03 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> I've implemented so you can drag text around in the text shape. It uses drag and drop so you can drag to and from other applications too
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoCanvasControllerWidgetViewport_p.cpp fab7c5c 
>   libs/flake/KoToolBase.h 0c0a9e4 
>   libs/flake/KoToolBase.cpp ae3482d 
>   libs/flake/KoToolProxy.h 8273980 
>   libs/flake/KoToolProxy.cpp 1e61e5c 
>   libs/kotext/KoTextDrag.h 9ad8560 
>   libs/kotext/KoTextDrag.cpp 5140785 
>   libs/kotext/KoTextEditor.h 616b320 
>   libs/kotext/KoTextEditor.cpp 60cff14 
>   libs/kotext/commands/ChangeTrackedDeleteCommand.cpp 562b726 
>   plugins/textshape/TextTool.h 5b42bb6 
>   plugins/textshape/TextTool.cpp 4078e72 
> 
> Diff: http://git.reviewboard.kde.org/r/104773/diff/
> 
> 
> Testing
> -------
> 
> Tried it as best I could to and from kate and internally in Words.
> 
> 
> Thanks,
> 
> C. Boemann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120429/194d9c4f/attachment.htm>