Review Request: Fixes: Calligra Words reads unit type setting only from ooo:view-settings, not from view-settings

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104701/#review12947
-----------------------------------------------------------


While trying to make the table resizing mode show correct units, I suddenly realized what this patch is all about.

I serious don't think we should load and save units as part of documents. SO my small change to fix the table resizing has now turned into a removal of the load and save in document. As a result I've also changed a little bit of your previous commit. So we now store the unit in KoCanvasResourceManager, and persist it in KConfig.

I'll Puh my branch later so you can see it it and possibly continu on it, since I pressed myself inoto you territory.

- C. Boemann


On April 26, 2012, 12:37 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104701/
> -----------------------------------------------------------
> 
> (Updated April 26, 2012, 12:37 a.m.)
> 
> 
> Review request for Calligra and Pierre Stirnweiss.
> 
> 
> Description
> -------
> 
> There is a mismatch between reading and writing of the config entry "unit" for a document:
> 
> all code writes that entry to "view-settings" group:
> KarbonPart::saveOasisSettings(...)
> KoPADocument::saveOdfSettings(...)
> DocBase::saveOdfHelper(...)
> KWOdfWriter::saveOdfSettings(...)
> 
> and most read it from there:
> KarbonPart::loadOasisSettings(...)
> KoPADocument::loadOdfSettings(...)
> DocBase::loadOdfSettings(...)
> 
> But KWOdfLoader::loadSettings(...) only read from old (before odf 1.2?) "ooo:view-settings", thus the bug.
> 
> While the attached patch fixes the bug, I wonder if KarbonPart, KoPADocument and DocBase should also try "ooo:view-settings" for backward-compability?
> Or should the patch be to just change "ooo:view-settings" to "view-settings", ignoring any backward compatibility?
> 
> I could not find any documentation on the setting properties for ODF, so need some with more clue to comment this.
> 
> 
> This addresses bug 298510.
>     http://bugs.kde.org/show_bug.cgi?id=298510
> 
> 
> Diffs
> -----
> 
>   words/part/KWOdfLoader.cpp c4cbcee 
> 
> Diff: http://git.reviewboard.kde.org/r/104701/diff/
> 
> 
> Testing
> -------
> 
> Created a new document with Calligra Words, changed the unit to Pica, saved it, closed Words. Restarted Words, load that document and see the settings updated to Pica (already with the tuneKoUnit branch merged to master locally)
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120426/d21d152c/attachment.htm>