Review Request: change Sheets UI by moving the cell editor out of the cell tool

[Marijn Kruisselbrink]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104708/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

This changes to UI of Calligra Sheets a bit by moving the cell editor widget out of the CellTool and instead have it as a separate docker. On top of that there are several new option widgets for the cell tool that provide common formatting options.
I've also changed the KoToolDocker a tiny bit, by changing the scroll area in it to not be able to get keyboard focus, at least for these new dockers that is preferred, I'm not sure if there are any other tool option widgets/use cases where you would want the scroll area containing the tool option widgets to be able to get keyboard focus?
Please test (also available in the tables-uirefactor-mek branch) and see if anything weird is happening since it is a fairly big change.


Diffs
-----

  libs/main/KoToolDocker.cpp 44ce789 
  sheets/CMakeLists.txt 5355719 
  sheets/Messages.sh e636ac1 
  sheets/part/CanvasItem.h 41acefe 
  sheets/part/CanvasItem.cpp c5ccba3 
  sheets/part/Factory.cpp fb612da 
  sheets/part/View.h 5322e43 
  sheets/part/View.cpp 5c11f98 
  sheets/ui/ActionOptionWidget.h PRE-CREATION 
  sheets/ui/ActionOptionWidget.cpp PRE-CREATION 
  sheets/ui/CellEditorDocker.h PRE-CREATION 
  sheets/ui/CellEditorDocker.cpp PRE-CREATION 
  sheets/ui/CellToolBase.h aa3a094 
  sheets/ui/CellToolBase.cpp 33f2d29 
  sheets/ui/CellToolBase_p.h 7750a4a 
  sheets/ui/CellToolBase_p.cpp 0cba586 
  sheets/ui/CellToolOptionWidget.h c46b7df 
  sheets/ui/CellToolOptionWidget.cpp 4a1d068 
  sheets/ui/CellToolOptionWidgets.xml PRE-CREATION 
  sheets/ui/ExternalEditor.h ab3ee6d 
  sheets/ui/ExternalEditor.cpp e9f8781 
  sheets/ui/LocationComboBox.h e666ada 
  sheets/ui/LocationComboBox.cpp 6215039 
  sheets/ui/Selection.h baa9cdf 
  sheets/ui/Selection.cpp 316a2fc 

Diff: http://git.reviewboard.kde.org/r/104708/diff/


Testing
-------


Thanks,

Marijn Kruisselbrink

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120424/3a4112d2/attachment.htm>