Review Request: Fixes: Calligra Words reads unit type setting only from ooo:view-settings, not from view-settings

C. Boemann cbr at boemann.dk
Mon Apr 23 17:16:42 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104701/#review12828
-----------------------------------------------------------


Hmm I think it's better to change the way we save so we are compatible with ooo.

Even LO uses ooo namespace, so for such easily interoparable settings i think it makes sense to just follow along

I would even go as far as saying the other calligra apps should be changed too

- C. Boemann


On April 23, 2012, 4:37 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104701/
> -----------------------------------------------------------
> 
> (Updated April 23, 2012, 4:37 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> There is a mismatch between reading and writing of the config entry "unit" for a document:
> 
> all code writes that entry to "view-settings" group:
> KarbonPart::saveOasisSettings(...)
> KoPADocument::saveOdfSettings(...)
> DocBase::saveOdfHelper(...)
> KWOdfWriter::saveOdfSettings(...)
> 
> and most read it from there:
> KarbonPart::loadOasisSettings(...)
> KoPADocument::loadOdfSettings(...)
> DocBase::loadOdfSettings(...)
> 
> But KWOdfLoader::loadSettings(...) only read from old (before odf 1.2?) "ooo:view-settings", thus the bug.
> 
> While the attached patch fixes the bug, I wonder if KarbonPart, KoPADocument and DocBase should also try "ooo:view-settings" for backward-compability?
> Or should the patch be to just change "ooo:view-settings" to "view-settings", ignoring any backward compatibility?
> 
> I could not find any documentation on the setting properties for ODF, so need some with more clue to comment this.
> 
> 
> This addresses bug 298510.
>     http://bugs.kde.org/show_bug.cgi?id=298510
> 
> 
> Diffs
> -----
> 
>   words/part/KWOdfLoader.cpp c4cbcee 
> 
> Diff: http://git.reviewboard.kde.org/r/104701/diff/
> 
> 
> Testing
> -------
> 
> Created a new document with Calligra Words, changed the unit to Pica, saved it, closed Words. Restarted Words, load that document and see the settings updated to Pica (already with the tuneKoUnit branch merged to master locally)
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120423/40f40c22/attachment.html>


More information about the calligra-devel mailing list