Review Request: Removed warning for 2.5. Using int for return type becuase -1 is a valid return

Jarosław Staniek staniek at kde.org
Sun Apr 22 21:49:26 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104691/#review12812
-----------------------------------------------------------

Ship it!


- Jarosław Staniek


On April 22, 2012, 3:28 p.m., Adam Pigg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104691/
> -----------------------------------------------------------
> 
> (Updated April 22, 2012, 3:28 p.m.)
> 
> 
> Review request for Calligra, Jarosław Staniek and Dag Andersen.
> 
> 
> Description
> -------
> 
> Removed warning for 2.5.  Using int for return type becuase -1 is a valid return
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/reports/kexidbreportdata.h c76a455a79e0364b0ff5c99646ddf7c8a55aa171 
>   kexi/plugins/reports/kexidbreportdata.cpp c3a6b2c70558c667764d61c035d5c62c43e13712 
>   kexi/plugins/reports/keximigratereportdata.h ff3607f3b5cbd2bae3aa11fac6eb40405152ecc2 
>   kexi/plugins/reports/keximigratereportdata.cpp 1ce11628c34402d361311f6fb26d20e5b83df461 
>   libs/koreport/common/KoReportData.h 3d0b6ef5e514dcc2bc1a201cb33f6f98357b6d04 
>   plan/libs/ui/reports/reportdata.h 3eb03a434ccdf299d5b24e44eebc575ce0a2919a 
>   plan/libs/ui/reports/reportdata.cpp 4e865bb73350ca62a307fe009a22cf17a0094051 
> 
> Diff: http://git.reviewboard.kde.org/r/104691/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Adam Pigg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120422/5cf2b715/attachment.htm>


More information about the calligra-devel mailing list