Review Request: Bug 298134: gcc 4.7 cannot save a ODF file or open a .doc file

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104677/#review12729
-----------------------------------------------------------


This review has been submitted with commit 11a852fda159100b30546a91e710fbbf1ca23e1c by Gopalakrishna Bhat A to branch calligra/2.4.

- Commit Hook


On April 19, 2012, 7:57 p.m., Gopalakrishna Bhat wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104677/
> -----------------------------------------------------------
> 
> (Updated April 19, 2012, 7:57 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> With gcc 4.7 installed we where not able to save a odt file because the xml file that was generated was missing the '>' for a tag. Example
>  <manifest:file-entry manifest:media-type="" manifest:full-path="Thumbnails/thumbnail.png"
>  </manifest:file-entry>
> 
> The missing close tag was because while doing a stack.pop the hasChildren (a bitfield) of Tag was not populated correctly. This patch fixes this problem.
> 
> 
> This addresses bug 298134.
>     http://bugs.kde.org/show_bug.cgi?id=298134
> 
> 
> Diffs
> -----
> 
>   libs/odf/KoXmlWriter.h 684871c 
> 
> Diff: http://git.reviewboard.kde.org/r/104677/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gopalakrishna Bhat
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120420/f45c0025/attachment.htm>