[calligra] /: Make calligra compile with clang
Stephen Kelly
steveire at gmail.com
Fri Apr 20 15:54:40 BST 2012
Boudewijn Rempt wrote:
> int n = name.indexOf(' ');
> - if (n != -1) {
> + if (n > -1) {
> kDebug(30518) << "Sheet name converting:" << name;
> - name[n] == '_';
> + name.replace(' ','_');
> kDebug(30518) << "Sheet name converted:" << name;
> }
> - name = name.replace(' ', "_");
You should try not to put things like this into a commit which is reportedly
only for fixing support for a compiler. Particularly the != > change
shouldn't be in such an 'ignorable' commit.
Thanks,
Steve.
More information about the calligra-devel
mailing list