Review Request: Fixes: show RulerTabChooser in right place, not somewhere on ruler, and only if needed/wanted

[Friedrich W. H. Kossebau]

> On April 19, 2012, 6:23 a.m., Boudewijn Rempt wrote:
> > It looks good to me. Krita doesn't need a tab chooser. (Well, technically, it could be useful if the active shape on a vector layer is a text shape, but I'm not sure that's something our users really care about.)

For consistency in all Calligra programs it could be there, but then it would be untypical for a pixel program. IMHO lets just see what the feedback of users is, if they start to write bug reports about missing it.

Thanks Boud and Adam for taking a look, happy that you like it. Now I just need another brave person to say ship it :)


- Friedrich W. H.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104666/#review12649
-----------------------------------------------------------


On April 19, 2012, 1:58 a.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104666/
> -----------------------------------------------------------
> 
> (Updated April 19, 2012, 1:58 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Currently in all programs (besides Words) the tab chooser is wrongly displayed somewhere on the horizontal ruler. And also if not needed, i.e. tabs are no property of the shape.
> 
> Attached patch fixes that:
> * it puts the tab chooser in the corner for Stage and Karbon (so not for Krita, because less text oriented)
> * it only creates the tab chooser on demand, not always (so it does not appear for Krita, like now)
> * it only shows the tabs chooser if tabs are also shown in the ruler
> 
> (not sure that there should be no tab chooser for Krita)
> 
> Candidate for 2.4 backport?
> 
> 
> Diffs
> -----
> 
>   karbon/ui/KarbonView.cpp 2b9a907 
>   libs/kopageapp/KoPAView.cpp fc28628 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 68a61f9 
>   libs/main/KoRuler.cpp 4272b9b 
>   libs/main/KoRulerController.cpp 39a2e3b 
>   libs/main/KoRuler_p.h bfeac46 
> 
> Diff: http://git.reviewboard.kde.org/r/104666/diff/
> 
> 
> Testing
> -------
> 
> Started Krita, Karbon, Stage, Words and activated text shapes, had rulers shown and not shown.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120420/80e8ffc8/attachment.htm>