Review Request: Bug 298134: gcc 4.7 cannot save a ODF file or open a .doc file

Gopalakrishna Bhat gopalakbhat at gmail.com
Thu Apr 19 20:57:43 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104677/
-----------------------------------------------------------

Review request for Calligra.


Description
-------

With gcc 4.7 installed we where not able to save a odt file because the xml file that was generated was missing the '>' for a tag. Example
 <manifest:file-entry manifest:media-type="" manifest:full-path="Thumbnails/thumbnail.png"
 </manifest:file-entry>

The missing close tag was because while doing a stack.pop the hasChildren (a bitfield) of Tag was not populated correctly. This patch fixes this problem.


This addresses bug 298134.
    http://bugs.kde.org/show_bug.cgi?id=298134


Diffs
-----

  libs/odf/KoXmlWriter.h 684871c 

Diff: http://git.reviewboard.kde.org/r/104677/diff/


Testing
-------


Thanks,

Gopalakrishna Bhat

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120419/3a8adce7/attachment.htm>


More information about the calligra-devel mailing list