Review Request: Krita /Calligra: add standard hover effect in item views

Boudewijn Rempt boud at valdyas.org
Thu Apr 12 15:50:10 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104556/#review12359
-----------------------------------------------------------

Ship it!


Looks good to me! Thanks!

- Boudewijn Rempt


On April 12, 2012, 2:21 p.m., Jean-Baptiste Mardelle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104556/
> -----------------------------------------------------------
> 
> (Updated April 12, 2012, 2:21 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> Currently in Krita's layer dialog, it is sometimes difficult to see which layer is the correct one. For example, check my screenshot: trying to select "Layer 104", it's hard to tell if it is the layer above or below the text label.
> 
> My patch adds the standard tree view hover effect in the layer dialog, which means that when moving mouse over a layer, it's much easier to find out which layer is where (see my second screenshot). My patch applies to all KoDocumentSectionDelegate in Calligra, which in my opinion improves the overall look and integration with other KDE applications.
> 
> 
> Diffs
> -----
> 
>   libs/main/KoDocumentSectionDelegate.cpp 3cb7b56 
> 
> Diff: http://git.reviewboard.kde.org/r/104556/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Krita layers
>   http://git.reviewboard.kde.org/r/104556/s/524/
> Krita with hover effect
>   http://git.reviewboard.kde.org/r/104556/s/525/
> 
> 
> Thanks,
> 
> Jean-Baptiste Mardelle
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120412/aacf65aa/attachment.htm>


More information about the calligra-devel mailing list