Review Request: remove redundant "Shadow" terms in shadow config widget

Boudewijn Rempt boud at valdyas.org
Wed Apr 11 18:24:46 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104550/#review12331
-----------------------------------------------------------

Ship it!


Yes, I think it's nicer this way.

- Boudewijn Rempt


On April 11, 2012, 5:08 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104550/
> -----------------------------------------------------------
> 
> (Updated April 11, 2012, 5:08 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> IMHO the term "Shadow" is only redundant inside the config and only makes the strings long, especially in translations.
> 
> 
> Diffs
> -----
> 
>   libs/widgets/KoShadowConfigWidget.ui 56e34d9 
> 
> Diff: http://git.reviewboard.kde.org/r/104550/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Before
>   http://git.reviewboard.kde.org/r/104550/s/519/
> After
>   http://git.reviewboard.kde.org/r/104550/s/520/
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120411/32c634c8/attachment.htm>


More information about the calligra-devel mailing list