[calligra] libs/flake/svg: correct result of my own brain damage

Friedrich W. H. Kossebau kossebau at kde.org
Fri Apr 6 09:48:41 BST 2012


Am Freitag, 6. April 2012, 10:17:09 schrieb Boudewijn Rempt:
> On Thursday 05 April 2012 Apr, Jan Hambrecht wrote:
> 
> It's maths so beyond me -- but if others agree that this is right, I can
> backport this morning.

Both fixes the bug (as in: the referenced test SVG with shearing now renders 
correctly) as looks mathematically correct (one radian is equal to 180/π 
degrees, so
 y radian = x degree <=> (substitute radian with degree)
 y 180/π degree = x degree <=> (multiply by 1/degree)
 y 180/π = x <=> (multiply with π/180)
 y = π/180 x)

Cheers
Friedrich

> > Git commit b5aa47b0459e9a51eb28cca423ad19e162e160de by Jan Hambrecht.
> > Committed on 05/04/2012 at 23:10.
> > Pushed by jaham into branch 'master'.
> > 
> > correct result of my own brain damage
> > 
> > this fixes parsing the skewX skewY svg transformations
> > 
> > please review and apply to 2.4 if appropriate
> > 
> > BUG: 297544
> > 
> > M  +6    -6    libs/flake/svg/SvgUtil.cpp
> > 
> > http://commits.kde.org/calligra/b5aa47b0459e9a51eb28cca423ad19e162e160de
> > 
> > diff --git a/libs/flake/svg/SvgUtil.cpp b/libs/flake/svg/SvgUtil.cpp
> > index b6f11d8..e500701 100644
> > --- a/libs/flake/svg/SvgUtil.cpp
> > +++ b/libs/flake/svg/SvgUtil.cpp
> > @@ -30,7 +30,7 @@
> > 
> >  #define DPI 72.0
> > 
> > -#define DEG2RAD(degree) degree*180.0/M_PI
> > +#define DEG2RAD(degree) degree/180.0*M_PI





More information about the calligra-devel mailing list