Review Request: Add new default marker style "Arrow concave", as found in LibreOffice 3.4.5

Thorsten Zachmann t.zachmann at zagge.de
Wed Apr 4 05:48:34 BST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104476/#review12150
-----------------------------------------------------------

Ship it!


Looks good please commit and backport to 2.4

- Thorsten Zachmann


On April 3, 2012, 12:35 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104476/
> -----------------------------------------------------------
> 
> (Updated April 3, 2012, 12:35 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> At least in my OpenSuse install LibreOffice 3.4.5 has an additional marker style in standard.soe (used for the default arrows), "Arrow concave", so Calligra better also has this one, right?
> 
> While I was at it, I also changed the draw:name and draw:display-name to something with more semantics, so one does not need to always draw the marker in ones head to know which one it is ;)
> 
> Okay to also backport to 2.4?
> 
> 
> Diffs
> -----
> 
>   libs/flake/styles/markers.xml 5b76cce 
> 
> Diff: http://git.reviewboard.kde.org/r/104476/diff/
> 
> 
> Testing
> -------
> 
> Set the new and old markers to arrows, saved and loaded files with these.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20120404/55f89aa3/attachment.htm>


More information about the calligra-devel mailing list