Review Request: Continue refactoring of Kotext/styles/KoTableBorderStyle and KoBorder

[C. Boemann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102724/#review6884
-----------------------------------------------------------


As I already said last night it looks ok in general, however when running cstester it revealed that outer borders of tables seem to have change color

and there is also a document where the table seem to have shifted position for no good reason (that maybe something else though).

for ref these are reminders of documents:
www.une.edu
www.alpineskihire


- C. Boemann


On Sept. 27, 2011, 11:49 p.m., Pierre Ducroquet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102724/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2011, 11:49 p.m.)
> 
> 
> Review request for Calligra and C. Boemann.
> 
> 
> Description
> -------
> 
> This patch removes almost everything that was left in KoTableBorderStyle and uses only KoBorder instead.
> 
> 
> Diffs
> -----
> 
>   filters/libmsooxml/MsooXmlDrawingTableStyleReader.cpp 86f07b1 
>   filters/libmsooxml/MsooXmlTableStyle.cpp 5f1de19 
>   filters/words/docx/DocxXmlDocumentReader.cpp 18f43fb 
>   filters/words/docx/DocxXmlStylesReader.cpp c859eca 
>   libs/kotext/KoTextEditor.cpp 9ff740c 
>   libs/kotext/styles/KoTableBorderStyle.h 6c24a75 
>   libs/kotext/styles/KoTableCellStyle.h 3d3379b 
>   libs/kotext/styles/KoTableCellStyle.cpp 1b6876c 
>   libs/odf/KoBorder.h 83cdac8 
>   libs/odf/KoBorder.cpp 1161a0a 
>   libs/textlayout/KoTextLayoutCellHelper.cpp 7d0dfd7 
>   words/part/KWCanvasBase.cpp fb7fc2c 
> 
> Diff: http://git.reviewboard.kde.org/r/102724/diff/diff
> 
> 
> Testing
> -------
> 
> Compiling, running kotext unit tests.
> 
> 
> Thanks,
> 
> Pierre Ducroquet
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110928/7ac1abd4/attachment.htm>