Review Request: Added Footnotes/Endnotes in References Tool

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102552/#review6858
-----------------------------------------------------------


When I add a review in the UI I get a crash with the following backtrace:

#6  parent (this=0x0) at ../../include/QtCore/../../src/corelib/kernel/qobject.h:250
#7  QTextObject::docHandle (this=0x0) at text/qtextobject.cpp:176
#8  0x00007f1503a47de6 in QTextFrame::begin (this=0x0) at text/qtextobject.cpp:625
#9  0x00007f1500f51ca7 in FrameIterator::FrameIterator (this=0x7fff66cd3e20, frame=0x0) at /home/tz/develop/kde/git/calligra/libs/textlayout/FrameIterator.cpp:33
#10 0x00007f1500f274bf in KoTextLayoutArea::preregisterFootNote (this=0x12d5350, note=0x304daa0) at /home/tz/develop/kde/git/calligra/libs/textlayout/KoTextLayoutArea.cpp:1542
#11 0x00007f1500f273d0 in KoTextLayoutArea::findFootNotes (this=0x12d5350, block=..., line=...) at /home/tz/develop/kde/git/calligra/libs/textlayout/KoTextLayoutArea.cpp:1529
#12 0x00007f1500f24d30 in KoTextLayoutArea::layoutBlock (this=0x12d5350, cursor=0x173d000) at /home/tz/develop/kde/git/calligra/libs/textlayout/KoTextLayoutArea.cpp:1114
#13 0x00007f1500f21b30 in KoTextLayoutArea::layout (this=0x12d5350, cursor=0x173d000) at /home/tz/develop/kde/git/calligra/libs/textlayout/KoTextLayoutArea.cpp:536
#14 0x00007f1500f3fc46 in KoTextLayoutRootArea::layoutRoot (this=0x12d5350, cursor=0x173d000) at /home/tz/develop/kde/git/calligra/libs/textlayout/KoTextLayoutRootArea.cpp:63
#15 0x00007f1500f41da2 in KoTextDocumentLayout::doLayout (this=0x1b463e0) at /home/tz/develop/kde/git/calligra/libs/textlayout/KoTextDocumentLayout.cpp:590
#16 0x00007f1500f419c4 in KoTextDocumentLayout::layout (this=0x1b463e0) at /home/tz/develop/kde/git/calligra/libs/textlayout/KoTextDocumentLayout.cpp:540

To reproduce 
- Open words with Professional Letter template
- Type "This is a test."
- Use the menu entry Insert > Footnote/Endnote... 
- Press enter
-> Crash


libs/kotext/KoInlineNote.cpp
<http://git.reviewboard.kde.org/r/102552/#comment6092>

    This line can be called with notesConfig not set as above there is a if and else if. Maybe add notesConfig to the if above.



libs/kotext/KoInlineTextObjectManager.cpp
<http://git.reviewboard.kde.org/r/102552/#comment6093>

    Are these includes needed?


- Thorsten Zachmann


On Sept. 24, 2011, 1:28 p.m., Brijesh Patel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102552/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2011, 1:28 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> I worked on implementation of Footnotes and Endnotes in Calligra Words as part of my SoK project.
> Footnotes/Endnotes can now be inserted,saved,loaded and also be configured too.
> Can somebody review my work and notify me about bugs/crashes?
> 
> 
> Diffs
> -----
> 
>   libs/kotext/KoInlineNote.h 515a2f3 
>   libs/kotext/KoInlineNote.cpp 89200fd 
>   libs/kotext/KoInlineTextObjectManager.h 44990e9 
>   libs/kotext/KoInlineTextObjectManager.cpp da8d9ca 
>   libs/kotext/KoTextDocument.h a79638c 
>   libs/kotext/KoTextDocument.cpp 1265e2c 
>   libs/kotext/KoTextEditor.h 4947db8 
>   libs/kotext/KoTextEditor.cpp d6d6738 
>   libs/kotext/opendocument/KoTextLoader.cpp 04ce705 
>   libs/kotext/styles/KoStyleManager.h bae6eaf 
>   libs/kotext/styles/KoStyleManager.cpp 650899d 
>   libs/odf/KoOdfNotesConfiguration.cpp bc26e31 
>   libs/odf/KoOdfNumberDefinition.cpp d35a07f 
>   libs/odf/KoOdfStylesReader.cpp 35bffce 
>   libs/textlayout/CMakeLists.txt 5a4bfff 
>   libs/textlayout/FrameIterator.h c8be153 
>   libs/textlayout/FrameIterator.cpp fe9824e 
>   libs/textlayout/KoTextLayoutArea.h 045419f 
>   libs/textlayout/KoTextLayoutArea.cpp fa50f5e 
>   libs/textlayout/KoTextLayoutArea_paint.cpp 6b3e293 
>   libs/textlayout/KoTextLayoutEndNotesArea.h 7b0c732 
>   libs/textlayout/KoTextLayoutEndNotesArea.cpp bb746db 
>   libs/textlayout/KoTextLayoutNoteArea.h PRE-CREATION 
>   libs/textlayout/KoTextLayoutNoteArea.cpp PRE-CREATION 
>   plugins/textshape/CMakeLists.txt 3df7aa5 
>   plugins/textshape/ReferencesTool.h c823be3 
>   plugins/textshape/ReferencesTool.cpp b210a35 
>   plugins/textshape/dialogs/NotesConfigurationDialog.h PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.cpp PRE-CREATION 
>   plugins/textshape/dialogs/NotesConfigurationDialog.ui PRE-CREATION 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.h 1af35a8 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.cpp 374b266 
>   plugins/textshape/dialogs/SimpleFootEndNotesWidget.ui 77f33e7 
>   plugins/textshape/pics/settings-icon1_1.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102552/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Brijesh Patel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20110927/8f5bf9cb/attachment.htm>